Configure max number of model instances #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow multiple instances of a model to be instantiated (think @wk1984's implementation of GIPL as a use case), the babelizer Fortran interoperability layer has a parameter
For models that use statically allocated variables, this presents a problem--2048 copies of a model with memory already allocated are created! This, I believe, is at the heart of the problem in csdms/help-desk#104.
In this PR, an undocumented
max_instancesparameter is added to the build section of the babelizer input file. It's set to a small default number (currently 8), which allows enough instances to be created to run the bmi-tester. Users can override this default value in the babelizer input file; e.g.:or
I'm choosing to keep this new parameter undocumented, pending further study.